CLI: print error source #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfchandler
force-pushed
the
wc/print-err-source
branch
from
dd741e3 to
d35dc80
Compare
Currently the `oxide` binary will print the error returned when a subcommand fails, but not any `source` errors attached to it. In the context of connection failures from the `auth login` subcommand, the output was only `Request failed`, giving the user no context on why the failure occurred. If present, append the source of the error to the user-facing message. Previously: ``` $ oxide auth login --host oxide.invalid Request failed ``` Now: ``` $ oxide auth login --host oxide.invalid Request failed: error sending request for url \ (http://oxide.invalid/device/auth): error trying to connect: dns \ error: failed to lookup address information: nodename nor servname \ provided, or not known ```
wfchandler
force-pushed
the
wc/print-err-source
branch
from
d35dc80 to
d13b4bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
oxidebinary will print the error returned when asubcommand fails, but not any
sourceerrors attached to it. In thecontext of connection failures from the
auth loginsubcommand, theoutput was only
Request failed, giving the user no context on why thefailure occurred.
If present, append the source of the error to the user-facing message.
Previously:
Now:
$ oxide auth login --host oxide.invalid Request failed: error sending request for url (http://oxide.invalid/device/auth): error trying to connect: dns error: failed to lookup address information: nodename nor servname provided, or not known